[Webkit-unassigned] [Bug 67798] DFG JIT completely undoes speculative compilation even in the case of a partial static speculation failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67798





--- Comment #7 from Gavin Barraclough <barraclough at apple.com>  2011-09-09 15:36:52 PST ---
(From update of attachment 106799)
View in context: https://bugs.webkit.org/attachment.cgi?id=106799&action=review

I think the mechanism implemented in this patch (reintroducing a dynamic bail to non-spec on terminateSpeculation) should be completely orthogonal to the DYNAMIC_OPTIMIZATION - we should be able to configure the two separately? - if so, it may make sense to land this under a separate #ifdef.  I'd suggest changing the ENABLE(DYNAMIC_OPTIMIZATION) tests into the code to something like ENABLE(DYNAMIC_TERMINATE_SPECULATIVE_JIT), & then "#define ENABLE_DYNAMIC_TERMINATE_SPECULATIVE_JIT ENABLE_DYNAMIC_OPTIMIZATION" in Platform.h.

r+ with at least a fix to DFG_DEBUG_VERBOSE.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:223
> +#if DFG_DEBUG_VERBOSE

This debug printf should be moved outside of the outer ifdef, such that it is printed for both ENABLE(DYNAMIC_OPTIMIZATION) & !ENABLE(DYNAMIC_OPTIMIZATION).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.