[Webkit-unassigned] [Bug 67756] Let TestWebKitAPI work for chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 10:35:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67756


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org




--- Comment #10 from Sam Weinig <sam at webkit.org>  2011-09-09 10:35:15 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Perhaps it would be best to follow the "config.h" approach of other WebKit projects (WebCore, WebKit2, etc.).
> 
> Is it OK to just rename TestWebKitAPI.h to config.h in my patch?
> 
> Or the following method?
> 1) rename TestWebKitAPIPrefix.h to config.h 
> 2) include config.h from each of the source files
> 3) disable original GCC_PREFIX_HEADER or ForceIncludeFiles
> 
> I prefer the former because the change is small and I don't need to verify my change on both Mac and Windows.

Please do the latter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list