[Webkit-unassigned] [Bug 67756] Let TestWebKitAPI work for chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67756





--- Comment #4 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-09-09 04:03:29 PST ---
(From update of attachment 106707)
View in context: https://bugs.webkit.org/attachment.cgi?id=106707&action=review

>> Source/WebKit/chromium/WebKit.gyp:2
>> +# Copyright (C) 2011 Google Inc. All rights reserved.
> 
> We usually just add the new year when this is updated, so 2010, 2011.

It's a common practice to use only the last year for Google copyrights, otherwise it should have been "2009, 2010".

>> Tools/Scripts/run-api-tests:69
>> +  --chromium            Run the Chromium port on Mac/Win/Linux
> 
> Why is this necessary?  Can't you just call isChromium()?

isChromium() just looks for '--chromium' in the command line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.