[Webkit-unassigned] [Bug 60430] selectstart is not fired when selection was created by arrow keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60430


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106844|review?                     |review-
               Flag|                            |




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-09 01:03:05 PST ---
(From update of attachment 106844)
View in context: https://bugs.webkit.org/attachment.cgi?id=106844&action=review

> Source/WebCore/editing/FrameSelection.cpp:825
> +        VisibleSelection trialVisibleSelection = trialFrameSelection.selection();
> +        bool change = shouldChangeSelection(trialVisibleSelection);

Why do we need to make a copy of VisibleSelection here?

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:13
> +div.addEventListener('selectstart', function (event) { selectStartCount++; });

We also need a test for preventing the default action.

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:58
> +         document.write('PASS.');

Nit: wrong indentation. Also maybe get rid of . at the end?

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:59
> +    document.writeln('<br />');

Don't think we should use XML-style br.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.