[Webkit-unassigned] [Bug 67767] Crashed in WebCore::AppendNodeCommand::create(WTF::PassRefPtr<WebCore::ContainerNode>, WTF::PassRefPtr<WebCore::Node>)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 00:54:49 PDT 2011


--- Comment #4 from Shinya Kawanaka <shinyak at google.com>  2011-09-09 00:54:49 PST ---
(In reply to comment #2)
> (From update of attachment 106728 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106728&action=review
> This looks OK. It's a little strange to just do nothing if the node is not an element and the patch would be better if it explained why that is the correct thing to do, not just that it won’t crash.

I added some explanation in a test case.

> > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:9
> > +    document.writeln("This test ensures WebKit does not crash.<br><br>PASS");
> The wording here is wrong. The test does not ensure that WebKit does not crash. The test has no effect on WebKit.


> It's good to say that the test has passed if it doesn’t crash, and also probably good to say as clearly as possible why there was a time when the test would crash.
> > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:12
> > +<meta content="2"/><body onLoad="runTest();">
> What is the significance of this "meta" element?

It did have no meaning. I removed it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list