[Webkit-unassigned] [Bug 67825] Implement a WebKitAnimationEvent constructor for JSC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 18:58:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67825





--- Comment #5 from Kentaro Hara <haraken at google.com>  2011-09-08 18:58:45 PST ---
(In reply to comment #3)
> (From update of attachment 106825 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106825&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        [Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
> > +        dictionary WebKitAnimationEventInit : EventInit {
> > +            DOMString animationName;
> > +            double elapsedTime;
> > +        }
> 
> This is not what the IDL would look like.  The constructor would be on the Event itself, not the Init.

Sorry for the confusion. I omitted the interface part since this patch does not change it....

[Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
interface WebKitAnimationEvent : Event {
    ...;
}

dictionary WebKitAnimationEventInit : EventInit {
    DOMString animationName;
    double elapsedTime;
}

I will correct Changelog as above. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list