[Webkit-unassigned] [Bug 66323] Rename FontGtk.cpp to FontPango.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66323


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106506|review?                     |review-
               Flag|                            |




--- Comment #26 from Martin Robinson <mrobinson at webkit.org>  2011-09-08 16:07:30 PST ---
(From update of attachment 106506)
View in context: https://bugs.webkit.org/attachment.cgi?id=106506&action=review

> Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:89
> +    const int nBoxes = cairo_region_num_rectangles(region);

nBoxes -> rectCount?

> Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:94
> +        cairo_rectangle_int_t box;
> +        cairo_region_get_rectangle(region, i, &box);
> +        cairo_rectangle(to, box.x, box.y, box.width, box.height);
> +    }

box -> rect?

> Source/WebCore/platform/graphics/pango/PangoUtilities.cpp:32
> +static cairo_region_t* getLineClipRegionFromLayoutIter(PangoLayoutIter *iter, int xOrigin, int yOrigin, const int *indexRanges, int nRanges)

The asterisk on indexRanges should be on the type name.

> Source/WebCore/platform/graphics/pango/PangoUtilities.cpp:43
> +        int nPixelRanges = 0;

nPixelRange -> pixelRangeCount.

> Source/WebCore/platform/graphics/pango/PangoUtilities.cpp:71
> +cairo_region_t* getClipRegionFromPangoLayoutLine(PangoLayoutLine* line, int xOrigin, int yOrigin, const int* indexRanges, int nRanges)

Instead of two variables to get the origin, I suggest using a const IntPoint&. It looks like the origin is always 0, 0? Perhaps just ditch the parameters altogether. nRanges -> rangeCount. Please try to avoid not-well-known abbreviations.

> Source/WebCore/platform/graphics/pango/PangoUtilities.h:31
> +cairo_region_t* getClipRegionFromPangoLayoutLine(PangoLayoutLine*, int, int, const int*, int);

You need the variable names here for generic types (int and int*).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.