[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 13:47:46 PDT 2011


--- Comment #19 from Tony Chang <tony at chromium.org>  2011-09-08 13:47:46 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > (From update of attachment 106550 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=106550&action=review
> > 
> > This patch is OK, but I'm worried it's going to hurt us in the long run.  Specifically, we want to move away from the --test-shell API and switch to the same API as the other DRTs.  This patch is basically adding a third API that we have to support.
> > 
> > That said, handling QUIT seems pretty harmless. I would perhaps remove the --send-ready command line option and just put that in platformInit() since I doubt the other chromium ports will ever use that flag.
> I have tried to put it there, but platformInit is too early in execution and flakiness still happens on Android. I admit it is only useful to Android, but I cannot come to a better way for now. When changing the --test-shell API, we can change it accordingly.

Can we put this behind an #if OS(ANDROID) block?  That seems like less complexity than a command line flag.

With that change, this LGTM, but I think we want to hide as much of the differences in NRWT as possible.  For example, rather than sending QUIT to drt, can we use adb to get the pid and send a kill command?  Or rather than having drt print #READY, can we send test URLs until we get text back from DRT?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list