[Webkit-unassigned] [Bug 40338] display:none element should not retain focus

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40338


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106741|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2011-09-08 08:32:33 PST ---
(From update of attachment 106741)
View in context: https://bugs.webkit.org/attachment.cgi?id=106741&action=review

WebKit bug fixes need to come with regression tests. Please create a test and include it in the patch along with the fix.

> Source/WebCore/dom/Element.cpp:1758
> +    Document* doc = document();

Please don’t use the abbreviation "doc" instead of a word. The preferred way to write this in WebKit code is:

    Document* document = this->document();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.