[Webkit-unassigned] [Bug 64071] new-run-webkit-tests does not support qt-arm or qt-4.8 results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64071


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |kkristof at inf.u-szeged.hu
                   |kit.org                     |




--- Comment #14 from Csaba Osztrogonac <ossy at webkit.org>  2011-09-08 06:02:50 PST ---
(In reply to comment #13)
> We would still need to add 4.7 as an explicit version number (I think), but otherwise NRWT should just work "out of the box" including getting the wk2 fallback path correctly then, right?

Do you mean we should add a qt-4.7 platform too?
And then the search paths would be in general: 
qt-wk2|none -> qt-(linux|win|mac) -> qt-(4.7|4.8) -> generic

examples:
qt-wk2 -> qt-linux -> qt-4.8 -> qt -> generic
          qt-linux -> qt-4.8 -> qt -> generic
          qt-linux -> qt-4.7 -> qt -> generic

It sounds good to me. Now wk2 won't depends on Qt version. (You can't build it with Qt 4.7, only Qt 5.0, so version will be qt-48 always, because qt-4.7 == Qt-4.7.x and qt-4.8 == Qt-4.8.x or newer)

We only need to add a Qt version checker function similar to in webkitdirs.pm:
sub getQtVersion()
{
    my $qtVersion = `$qmakebin --version`;
    $qtVersion =~ s/^(.*)Qt version (\d\.\d)(.*)/$2/s ;
    return $qtVersion;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.