[Webkit-unassigned] [Bug 67584] [Chromium] Add WebSandboxSupport and WebThemeEngine for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67584





--- Comment #18 from Hao Zheng <zhenghao at chromium.org>  2011-09-08 01:31:06 PST ---
(In reply to comment #17)
> (From update of attachment 106385 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106385&action=review
> 
> > Source/WebKit/chromium/public/android/WebSandboxSupport.h:38
> > +class WebSandboxSupport {
> 
> I'm confused about why you need this.  Ordinarily, this is only required if someone actually tries to use the pointer returned via WebKitPlatformSupport::sandboxSupport().  Otherwise the "class WebSandboxSupport;" forward decl should be sufficient.

Hi Darin,
Code won't compile if we don't supply WebSandboxSupport.h.

third_party/WebKit/Source/WebKit/chromium/src/PlatformSupport.cpp:55:31: error: WebSandboxSupport.h: No such file or directory
make: *** [out/Release/obj.target/webkit/third_party/WebKit/Source/WebKit/chromium/src/PlatformBridge.o] Error 1

Shall I use some OS guard to exclude it on Android?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.