[Webkit-unassigned] [Bug 64459] [GTK] WebKitWebView should obey gtk-dnd-drag-threshold setting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64459





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-07 23:57:48 PST ---
(From update of attachment 100718)
View in context: https://bugs.webkit.org/attachment.cgi?id=100718&action=review

> Source/WebCore/page/gtk/EventHandlerGtk.cpp:144
> +    Page* page = m_frame->page();
> +    if (page) {
> +        Chrome* chrome = page->chrome();
> +        if (chrome) {
> +            GtkWidget* client = GTK_WIDGET(chrome->platformPageClient());
> +            gint widgetDragHysteresis = 0;
> +            if (client) {
> +                g_object_get(gtk_widget_get_settings(client),
> +                    "gtk-dnd-drag-threshold", &widgetDragHysteresis,
> +                    0);
> +                threshold = max(widgetDragHysteresis, threshold);
> +            }
> +        }
> +    }

Since WebKitGtk is not currently multi-head safe, I think all of this can be simplified as:

g_object_get(gtk_settings_get_default(), "gtk-dnd-drag-threshold", &gtkDndThreshold, NULL);
threshold = max(gtkDdnThreshold, threshold);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.