[Webkit-unassigned] [Bug 67750] Create a delegate class to help cleanly isolate the chromium compositor API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 20:05:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67750





--- Comment #2 from Nat Duca <nduca at chromium.org>  2011-09-07 20:05:45 PST ---
(From update of attachment 106676)
View in context: https://bugs.webkit.org/attachment.cgi?id=106676&action=review

I think there are references to GraphicsLayer on CCLayerTreeHost as well for the root layer.

Did you add CCLayerDelegate.h? I dont see the actual class...

I don think you need to call the virtual methods on those doPaintGraphicsLayerContents... paintContents should work just fine. GraphicsLayer is supposed to go away from the Layer tree completely.

git grep for graphicslayer --- it should be gone from all compositor related files when this patch lands.

> Source/WebCore/ChangeLog:3
> +        Added a pure virtual class CCLayerDelegate which helps to isolate

I think the traditional format of changelog entries is a short sumary, the bug# ,then a detailed summary if need. i might be wrong...

> Source/WebCore/WebCore.gypi:3537
> +            'platform/graphics/chromium/cc/CCLayerDelegate.h',

My preference would be for this to be in LayerChromium.h file, which is sort of how we've doing client classes as well, c.f. CCLayerTreeHost and CCLayerTreeHostClient, which are the same file.

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:704
> +void GraphicsLayerChromium::doPaintGraphicsLayerContents(GraphicsContext& context, const IntRect& clip)

Is there a way to do this without to doPaint?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list