[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67590





--- Comment #17 from Hao Zheng <zhenghao at chromium.org>  2011-09-07 18:25:40 PST ---
(In reply to comment #16)
> (From update of attachment 106550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106550&action=review
> 
> This patch is OK, but I'm worried it's going to hurt us in the long run.  Specifically, we want to move away from the --test-shell API and switch to the same API as the other DRTs.  This patch is basically adding a third API that we have to support.
> 
> That said, handling QUIT seems pretty harmless. I would perhaps remove the --send-ready command line option and just put that in platformInit() since I doubt the other chromium ports will ever use that flag.

I have tried to put it there, but platformInit is too early in execution and flakiness still happens on Android. I admit it is only useful to Android, but I cannot come to a better way for now. When changing the --test-shell API, we can change it accordingly.

> 
> I think most of the difficulty in maintaining this is going to end up in new-run-webkit-tests.  Maybe abarth or dpranke have an opinion about this.
> 
> > Source/WebKit/chromium/WebKit.gyp:1131
> > +                ['OS=="android"', {
> > +                    # FIXME(zhenghao): Reserve for upstream in the near future.
> > +                },{ # OS!="android"
> 
> Nit: I would still remove this and empty block and just add it in the next patch.

Ok.

> 
> > Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:84
> > +void openStartupDialog()
> > +{
> > +    // Nothing to do here.
> > +}
> 
> On second thought, I think a notImplemented() is appropriate here.  You only get here if --testshell-startup-dialog is passed on the command line (normally for debugging).  It seems like in that case you would want to print something to stdout.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.