[Webkit-unassigned] [Bug 66887] CSS rules not being applied when a hidden field is inserted between an input[type=checkbox] and a label

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66887


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106612|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Dave Hyatt <hyatt at apple.com>  2011-09-07 13:08:39 PST ---
(From update of attachment 106612)
This patch isn't quite right. Here are the issues I see:

(1) What's the point of keeping childrenAffectedByDirectAdjacentRules once you change it to track a bool in the children instead? You shouldn't need both flags.

(2) If you eliminate the parent flag, then what you're really patching is "forceCheckOfNextElementSibling". You can basically set that to true if the next sibling is affected by direct adjacent rules. Otherwise you don't have to do anything.

Let me know if I'm mistaken, but it sure looks like you don't need to keep around the other flag any longer with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.