[Webkit-unassigned] [Bug 67511] Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67511





--- Comment #25 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-09-07 10:46:55 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > (From update of attachment 106465 [details] [details])
> > You probably want to add
> > 
> >     if (!window.internals)
> >         return;
> > 
> > to your layout tests. Other than that, looks fine to me, but I'm not a reviewer.
> 
> I'm just curious - does this really matter?
> 
> I don't mind adding it if it's desired, but it goes against "keep layout tests as small as possible" and doesn't really add anything useful imho (i.e. the tests aren't going to work outside of the test infrastructure anyway - does it matter that they throw a JS exception in that case?).
> 
> Though, perhaps there's something I'm missing - in which case, let me know and I'll add these.

Yes! We should add the checks. The general expectation in LayoutTests directory is that the tests should run standalone. If the harness plumbing is required, they should warn you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.