[Webkit-unassigned] [Bug 67702] [Qt] Remove Qt specific code from css/SelectorChecker.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67702





--- Comment #2 from Andras Becsi <abecsi at webkit.org>  2011-09-07 10:25:06 PST ---
(In reply to comment #0)
> This code introduced in http://trac.webkit.org/changeset/43052/trunk/WebCore/css/CSSStyleSelector.cpp
> and a refactoring of this code (http://trac.webkit.org/changeset/94656) showed that there are
> Qt specific code here (build fail), but in general code it isn't acceptable.

I have a work-in-progress patch which moves this logic to the platform specific WebPlatformStrategies, so we could deal with the QWebHistoryInterface visited link check in the platformStrategies()->visitedLinkStrategy()->isLinkVisited call to avoid the layering violation.

This unfortunately would break the visited link detection on a Qt build where PLATFORM_STRATEGIES is disabled.
A possible solution for this would be to only support global history if PLATFORM_STRATEGIES is enabled. Tomorrow I'll upload the patch for feedback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.