[Webkit-unassigned] [Bug 67192] API to set initial focus in gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67192


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106552|review?                     |review-
               Flag|                            |




--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2011-09-07 07:44:39 PST ---
(From update of attachment 106552)
View in context: https://bugs.webkit.org/attachment.cgi?id=106552&action=review

> Source/WebKit/gtk/tests/testwebview.c:390
> +
> +    gtk_widget_show_all(window);
> +    g_signal_connect(window, "map-event",
> +                     G_CALLBACK(map_event_cb), loop);
> +    g_main_loop_run(loop);
> +
> +    webkit_web_view_load_uri(view, uri);
> +    g_main_loop_run(loop);
> +
> +    webkit_web_view_set_initial_focus(view, true);
> +    g_main_loop_run(loop);
> +
> +    g_free(uri);
> +    gtk_widget_destroy(window);

Your test has no assertions!

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4031
> + * Set the initial focus element.

Even with this documentation, I'm still not sure what this API does or how it works. I think this could be exanded greatly here. Does GTK+ even have the concept of focus direction? What situations is this API useful?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.