[Webkit-unassigned] [Bug 49904] [GTK] Add a signal to allow applications to handle its own context menu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 07:38:54 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=49904





--- Comment #32 from Martin Robinson <mrobinson at webkit.org>  2011-09-07 07:38:54 PST ---
(In reply to comment #30)

> > > Source/WebKit/gtk/webkit/webkitwebview.cpp:2775
> > > +     * @keyboard_mode: %TRUE if the context menu was triggered using the keyboard
> > 
> > Instead of keyboard_mode I'd prefer a name like triggered_with_keyboard.
> 
> I used keyboard_mode for consistency with GTK API, see for example:

I think maybe the GTK+ API is being a bad example here. I can't think of any issues with spending a few more characters to make the variable name clearer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list