[Webkit-unassigned] [Bug 60430] selectstart is not fired when selection was created by arrow keys

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 05:15:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60430


Arko Saha <nghq36 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nghq36 at motorola.com




--- Comment #5 from Arko Saha <nghq36 at motorola.com>  2011-09-07 05:15:36 PST ---
Hi Ryosuke,
Thanks for the review.

> 
> This is too late. m_selection.m_isDirectional has already been modified at 
> this point. r- because of this. You should probably do this in the if- 
> statement at the beginning of this function.

We can do this at the beginning of this function. But in IMHO if we keep this in the if-statement at the beginning, selectStart might not execute if modify() function called by JS.

> Why do we need all this code?

Here we need to find out selectStart target if the element is content editable, Similar as in case of selectAll(), how the selectStart event is fired.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list