[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67590


Hao Zheng <zhenghao at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106403|0                           |1
        is obsolete|                            |
 Attachment #106403|review?                     |
               Flag|                            |
 Attachment #106550|                            |review?
               Flag|                            |




--- Comment #15 from Hao Zheng <zhenghao at chromium.org>  2011-09-07 00:10:42 PST ---
Created an attachment (id=106550)
 --> (https://bugs.webkit.org/attachment.cgi?id=106550&action=review)
Proposed patch 5.

> > 
> > > Tools/DumpRenderTree/chromium/TestShellGtk.cpp:-188
> > > -    signal(SIGALRM, SIG_DFL);
> > 
> > Why don't we need to reset the previous handler?
> 
> alarmAction.sa_flags = SA_RESETHAND;
> This will reset the handler.

Sorry, I'm wrong at this point. SA_RESETHAND will only reset handler when the signal is received. Seems we only need to install the handler once for DRT, and no need to install&reset handler for every test. But I still keep it the old way here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.