[Webkit-unassigned] [Bug 67079] Replace usages of Vector<UChar> with existing StringBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 21:09:50 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67079


Xianzhu Wang <wangxianzhu at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105766|0                           |1
        is obsolete|                            |
 Attachment #106540|                            |commit-queue?
               Flag|                            |




--- Comment #16 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-09-06 21:09:49 PST ---
Created an attachment (id=106540)
 --> (https://bugs.webkit.org/attachment.cgi?id=106540&action=review)
patch resolved conflicts

Note of changes compared with the last patch:

1. StringBuilder.h: Still use StringImpl::characters() because of StringBuilder::characters() (was changed to use [] in bug 67340). As discussed in bug 66286 and bug 66706, eventually we'll use StringConstCharacterIterator as the return type of String::characters() (the function name may be changed).

2. To avoid conflict between WTF::double_conversion::StringBuilder and WTF::StringBuilder, added a typedef in NumberPrototype.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list