[Webkit-unassigned] [Bug 64546] Redrawing dirty parts of a large table is very slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64546


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106453|review?                     |review-
               Flag|                            |




--- Comment #10 from Sam Weinig <sam at webkit.org>  2011-09-06 18:42:31 PST ---
(From update of attachment 106453)
View in context: https://bugs.webkit.org/attachment.cgi?id=106453&action=review

> Source/WebCore/rendering/RenderTable.cpp:434
> +    if (!m_collapsedBordersValid) {
> +        m_collapsedBordersValid = true;

This should use an early return.

> Source/WebCore/rendering/RenderTable.h:263
> +    CollapsedBorderValues m_collapsedBorders;

This seems like it is making all RenderTables much much bigger (sizeof(CollapsedBorderValues) * 100).  Why is that ok?

> Source/WebCore/rendering/RenderTableCol.cpp:50
> +    if (table() && style() && style()->border() != newStyle->border())
> +            table()->invalidateCollapsedBorders();

The indentation is wrong here.

> Source/WebCore/rendering/RenderTableSection.cpp:83
> +    if (table() && style() && style()->border() != newStyle->border())
> +            table()->invalidateCollapsedBorders();

The indentation is wrong here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.