[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 6 18:18:04 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=67590
--- Comment #13 from Tony Chang <tony at chromium.org> 2011-09-06 18:18:04 PST ---
(In reply to comment #12)
> (From update of attachment 106403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106403&action=review
>
> >> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:81
> >> +}
> >
> > notImplemented()
>
> I thought that notImplemented() was for methods that aren't (yet) implemented because we don't expect them to be called? I think that here, that's not the case. These methods are expected to be called, but the implementation is intentionally empty. Is there a function or macro to denote that, or is a comment best?
In that case, I agree that a comment would be better. Something along the lines of, "// Nothing to do here."
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list