[Webkit-unassigned] [Bug 67645] Split Tap gesture detection into TapDown and TapRelease

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67645





--- Comment #7 from Varun Jain <varunjain at chromium.org>  2011-09-06 16:20:03 PST ---
(In reply to comment #6)
> (From update of attachment 106420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106420&action=review
> 
> the fact that the unit tests haven't been updated would seem to indicate that I didn't write enough unit tests. Perhaps you could add some?

Done.

> 
> Also: the why of this is important. You'll want to align this with qt port's work on adding the link preview.
> 
> > Source/WebCore/page/EventHandler.cpp:2240
> > +    case PlatformGestureEvent::TapDownType:
> 
> nit: TapDown should come above TapType.

Done.

> 
> > Source/WebCore/platform/PlatformGestureEvent.h:42
> > +        TapType,
> 
> this re-ordering would break a binary interface. Please leave TapType unchanged.

Done.

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:70
> >      void appendClickGestureEvent(const PlatformTouchPoint&, Gestures);
> 
> might be nice to rename this to appendTapGestureEvent? Am not sure it matters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.