[Webkit-unassigned] [Bug 67648] Move SelectorChecker out from the CSSStyleSelector scope

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67648


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-09-06 12:24:46 PST ---
Attachment 106464 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
[5]
Source/WebCore/css/CSSStyleSelector.h:195:  The parameter name "rule" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:225:  The parameter name "decl" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:250:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/css/CSSStyleSelector.h:251:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/css/CSSStyleSelector.h:320:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/CSSStyleSelector.h:322:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.h:55:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/SelectorChecker.h:78:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/SelectorChecker.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:57:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:242:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:315:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:373:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/SelectorChecker.cpp:472:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:599:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:604:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/css/SelectorChecker.cpp:931:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:995:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:1101:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:1111:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 27 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.