[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67590





--- Comment #11 from Tony Chang <tony at chromium.org>  2011-09-06 11:56:17 PST ---
(From update of attachment 106403)
View in context: https://bugs.webkit.org/attachment.cgi?id=106403&action=review

> Source/WebKit/chromium/WebKit.gyp:1131
> +                ['OS=="android"', {
> +                    # FIXME(zhenghao): Reserve for upstream in the near future.
> +                },{ # OS!="android"

This is weird.  Just flip your condition (OS!="android") and remove the else clause.

> Tools/ChangeLog:11
> +        - Wait until receiving '#READY' from DRT, so that DRT won't miss any
> +        input commands before it starts.

Can you explain your architecture to me?  It sounds like DRT runs on Android, but it's not clear to me if new-run-webkit-tests runs on Android or the desktop.

It seems unfortunate that DRT needs to acknowledge that it has started so I was trying to brainstorm ways to avoid this.

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:151
> +    bool sendReady = false; // Effective only in testShellMode.

Maybe print a warning to stderr if --send-ready is used without --test-shell?

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:41
> +static void AlarmHandler(int signatl)

Nit: Remove signatl (WebKit style normally just omits unused params)?

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:81
> +{
> +}

notImplemented()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.