[Webkit-unassigned] [Bug 67634] De-virtualize styleForRenderer()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67634





--- Comment #4 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-09-06 08:42:14 PST ---
(From update of attachment 106399)
View in context: https://bugs.webkit.org/attachment.cgi?id=106399&action=review

I am pretty sure cutomStyleForRenderer is killable too. It's definitely possible to kill custom style resolution on TextControlInnerElements. I should look at that.

> Source/WebCore/dom/NodeRenderingContext.cpp:303
> +    Element* element = node->isElementNode() ? toElement(node) : 0;
> +    if (element)
> +        m_context.setStyle(element->styleForRenderer());
> +    else if (RenderObject* parentRenderer = m_context.parentRenderer())
> +        m_context.setStyle(parentRenderer->style());

This is much cleaner, thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.