[Webkit-unassigned] [Bug 64733] Forms with display:none on the submit button do not get submitted on enter

Tue Sep 6 08:35:26 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64733

--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-06 08:35:25 PST ---
(From update of attachment 106402)
View in context: https://bugs.webkit.org/attachment.cgi?id=106402&action=review

> LayoutTests/fast/forms/hidden-submit-button-form-action.html:1
> +<html>

Nit: is there a reason we don't have a DOCTYPE here? As far as I can tell, the bug reproduces on both quirks and strict modes.

> LayoutTests/fast/forms/hidden-submit-button-form-action.html:4
> +    <form onsubmit="log('PASS'); return false;">
> +        This tests that hitting the enter key on a input box element with hidden submit button submits the form.<br>

Nit: I don't think there's need for indenting elements like this.

The reason I advocate for not-indenting text/elements is that indentation takes space. Since the "svn up" time is constantly complained about, we should try to minimize the file size as much.

> LayoutTests/fast/forms/hidden-submit-button-form-action.html:11
> +    var textbox2 = document.getElementById('textbox2');

Nit: I don't think there's need for indenting scripts.

> LayoutTests/fast/forms/hidden-submit-button-form-action.html:18
> +    function log(msg) {
> +    var console = document.getElementById('console');

If you just outdent function log(msg) { and }, then the function definition will be properly indented as in:
function log(msg) {
    var console = document.getElementById('console');
    console.innerHTML = console.innerHTML + msg + "<br>";
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.