[Webkit-unassigned] [Bug 67645] Split Tap gesture detection into TapDown and TapRelease

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67645





--- Comment #4 from Varun Jain <varunjain at chromium.org>  2011-09-06 08:16:01 PST ---
(In reply to comment #2)
> (From update of attachment 106416 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106416&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:2239
> > +    case PlatformGestureEvent::TapDownType:
> 
> you should have removed click

I think TapType is required for EventHandler to differentiate between TapRelease and click. I agree that TapRelease is redundant right now. However, what if a webapp wants to know about TapRelease (for instance in a drag and drop session)? ScrollBegin/End probably encapsulates that case so I am not sure about it. I will remove TapRelease for now and we can add it later if required.

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:100
> > +void GestureRecognizerChromium::appendTapReleaseGestureEvent(const PlatformTouchPoint& touchPoint, Gestures gestures)
> 
> why have you not deleted appendClick*?
> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:182
> > +    appendTapReleaseGestureEvent(point, gestures);
> 
> I do not believe that TapRelease should be generated here. ScrollEnd already signifies that the finger has left the screen surface and has left it from a scroll gesture. This additional event is wrong.
> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:71
> >      void appendClickGestureEvent(const PlatformTouchPoint&, Gestures);
> 
> this one... why is it still here?
> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.h:93
> > +    IntPoint m_lastTouchScreenPosition;
> 
> this variable is superfluous as you have the desired value from the PlatformTouchPoint event in appendTapRelease* Why?
> 
> > Source/WebCore/platform/chromium/PopupContainer.cpp:316
> > +    case PlatformGestureEvent::TapDownType:
> 
> you should have removed click type

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.