[Webkit-unassigned] [Bug 67645] Split Tap gesture detection into TapDown and TapRelease

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 07:55:16 PDT 2011


--- Comment #2 from Robert Kroeger <rjkroege at chromium.org>  2011-09-06 07:55:16 PST ---
(From update of attachment 106416)
View in context: https://bugs.webkit.org/attachment.cgi?id=106416&action=review

> Source/WebCore/page/EventHandler.cpp:2239
> +    case PlatformGestureEvent::TapDownType:

you should have removed click

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:100
> +void GestureRecognizerChromium::appendTapReleaseGestureEvent(const PlatformTouchPoint& touchPoint, Gestures gestures)

why have you not deleted appendClick*?

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:182
> +    appendTapReleaseGestureEvent(point, gestures);

I do not believe that TapRelease should be generated here. ScrollEnd already signifies that the finger has left the screen surface and has left it from a scroll gesture. This additional event is wrong.

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:71
>      void appendClickGestureEvent(const PlatformTouchPoint&, Gestures);

this one... why is it still here?

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:93
> +    IntPoint m_lastTouchScreenPosition;

this variable is superfluous as you have the desired value from the PlatformTouchPoint event in appendTapRelease* Why?

> Source/WebCore/platform/chromium/PopupContainer.cpp:316
> +    case PlatformGestureEvent::TapDownType:

you should have removed click type

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list