[Webkit-unassigned] [Bug 66937] Padding size of input type search element is not locked on Webkit-GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66937





--- Comment #5 from Sameer Patil <mkrp87 at motorola.com>  2011-09-06 06:58:03 PST ---
(From update of attachment 105182)
View in context: https://bugs.webkit.org/attachment.cgi?id=105182&action=review

>> Source/WebCore/ChangeLog:11
>> +        (WebCore::RenderThemeGtk::adjustSearchFieldStyle):
> 
> Please fill these in.

Added details regarding change.

>> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:375
>> +        style->setOutlineOffset(-2);
> 
> I don't see this on other platforms at all. It seems unrelated. Why is it here?

This has been done for focusring. It has been there on windows platform(WebCore/rendering/RenderThemeWin.cpp). If focus ring is enabled and if we do active input type search element by clicking it then focus ring will look outset. Please check screenshot showing comparison of focusring behavior when we do and don't set outline offset on input type search element.

>> LayoutTests/fast/forms/search-styled-padding.html:15
>> +</html>
> 
> It seems like this test case could be greatly simplified. Should a text input type="search" field with some padding suffice? Is this covered by any existing tests? Be sure to generate your results with HEAD, as we've switched to GTK+ 3.x now.

I have added simplified Layout test for input type="search" element. All the parameters(padding size) of test is not covered by single test for input type search elements so added one. Yes I have generated the test results with the head.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.