[Webkit-unassigned] [Bug 67584] [Chromium] Add WebSandboxSupport and WebThemeEngine for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67584





--- Comment #13 from Hao Zheng <zhenghao at chromium.org>  2011-09-06 03:02:03 PST ---
(In reply to comment #12)
> (From update of attachment 106385 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106385&action=review
> 
> LGTM

Thanks!

> 
> > Source/WebKit/chromium/public/android/WebSandboxSupport.h:2
> > + * Copyright (C) 2010 Google Inc. All rights reserved.
> 
> s/2010/2011

Ok.

> 
> > Source/WebKit/chromium/public/android/WebSandboxSupport.h:36
> > +// FIXME: Empty class for now, as we need it to compile.
> 
> Please link to a bug so this ugliness doesn't get forgotten about.
> 

Actually, I don't think it's ugly at all. All we need is a null class to conform to the APIs. And we don't have any methods in our own code (not yet upstreamed code) also, until now at least. It's same as extracting an interface, and providing some substantial implementation on some ports, and providing a null implementation on other ports. If we don't expect to add any methods there, shall I file a bug?

> > Source/WebKit/chromium/public/android/WebSandboxSupport.h:37
> > +// Put methods here that are required due to sandbox restrictions.
> 
> I don't think this comment is needed
> 
> > Source/WebKit/chromium/public/android/WebThemeEngine.h:2
> > + * Copyright (C) 2010 Google Inc. All rights reserved.
> 
> s/2010/2011

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.