[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67590





--- Comment #8 from Steve Block <steveblock at google.com>  2011-09-06 02:35:41 PST ---
(From update of attachment 106387)
View in context: https://bugs.webkit.org/attachment.cgi?id=106387&action=review

> Source/WebKit/chromium/WebKit.gyp:1130
> +                    # FIXME(zhenghao): Reserve for upstream in the near future.

This wasn't in the previous patch and I don't understand the comment. Can you explain?

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:74
> +// TODO: Implement the following metheds if needed.

WebKit uses FIXME, not TODO. And this is rather vague. If you don't know of a reason why they'd be used, I don't think you should use a FIXME - use 'not required on Android' or an ASSERT_NOT_REACHED(). This can always be changed if we later find a reason why they're needed.

> Tools/DumpRenderTree/chromium/TestShellGtk.cpp:180
> +    alarmAction.sa_flags = SA_RESETHAND;

Mention this fix in the ChangeLog

> Tools/DumpRenderTree/chromium/TestShellGtk.cpp:-188
> -    signal(SIGALRM, SIG_DFL);

Why don't we need to reset the previous handler?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.