[Webkit-unassigned] [Bug 67176] JavaScriptCore does not have tiered compilation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67176





--- Comment #41 from Filip Pizlo <fpizlo at apple.com>  2011-09-05 23:40:31 PST ---
(In reply to comment #40)
> (In reply to comment #39)
> > Created an attachment (id=106384)
 --> (https://bugs.webkit.org/attachment.cgi?id=106384&action=review) [details] [details]
> > the patch - more fix review, sort of
> > 
> > This removes branchAdd32 from MacroAssembler86Common, but still calls the absolute one branchAdd32Absolute due to C++ overload hiding rules.  I'm happy to use some other strategy to get around the overload hiding ... this was just the one I thought was least evil.
> 
> Ah! - I see - you just need to add a using directive in the MacroAssemblerX86/MacroAssemblerX86_64 classes:
>     using MacroAssemblerX86Common::branchAdd32;
> 
> You should see a bunch of them at these head of these classes already, around lines 45-55 of both files.

Ah, that's pretty cool.  I didn't know using was that powerful! :-)  OK, I've fixed this and will commit with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.