[Webkit-unassigned] [Bug 67192] API to set initial focus in gtk webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 4 23:53:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67192





--- Comment #4 from Antaryami Pandia <xqb748 at motorola.com>  2011-09-04 23:53:04 PST ---
(In reply to comment #3)
> (From update of attachment 105619 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105619&action=review
> 
> > Source/WebKit/gtk/webkit/webkitwebview.cpp:4026
> > +void webkit_web_view_set_initial_focus(WebKitWebView* webView, gboolean forward)
> 
> This needs API documentation and a unit test.

By documentation do you mean the comments present for other APIs, for eg. "webkit_web_view_go_to_back_forward_item()"?

If possible could you please provide any reference to the existing API unit test.That would be helpful.

> > Source/WebKit/gtk/webkit/webkitwebview.cpp:4027
> > +{
> 
> Why no g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));?

Ok.Will change accordingly.

> > Source/WebKit/gtk/webkit/webkitwebview.cpp:4030
> > +    Page* page = core(webView);
> > +
> > +    if (page && page->focusController()) {
> 
> Please use an early return here.

Ok.Will change accordingly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list