[Webkit-unassigned] [Bug 67056] Logic from HTMLElement::deprecatedCreateContextualFragment moved into Range::createContextualFragment function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67056


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106290|review?                     |review+
               Flag|                            |




--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-04 18:02:45 PST ---
(From update of attachment 106290)
View in context: https://bugs.webkit.org/attachment.cgi?id=106290&action=review

> Source/WebCore/dom/Range.cpp:1145
> +            Node* firstChild = element->firstChild();
> +            if (firstChild)
> +                nextNode = firstChild;

firstChild can be declared inside if to limit the scope as in:
if (Node* firstChild = element->firstChild())
    nextNode = firstChild;

> Source/WebCore/editing/markup.cpp:687
>      // We use a fake body element here to trick the HTML parser to using the
> -    // InBody insertion mode.  Really, all this code is wrong and need to be
> -    // changed not to use deprecatedCreateContextualFragment.
> +    // InBody insertion mode.

The entire comment seems to fit in one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.