[Webkit-unassigned] [Bug 67056] Logic from HTMLElement::deprecatedCreateContextualFragment moved into Range::createContextualFragment function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67056





--- Comment #19 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2011-09-03 05:51:18 PST ---
Thanks for review Ryosuke. Please check my reply below.

(In reply to comment #17)
> (From update of attachment 106141 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106141&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        Logic from HTMLElement::deprecatedCreateContextualFragment moved into
> > +        Range::createContextualFragment function.
> 
> This line should match the bug title You should either rename the bug or replace this line by the actual bug title.
> 
Changed the bug title. That's more relevant.
> > Source/WebCore/ChangeLog:8
> > +
> 
> You should add description here (keep the blank line after Reviewed by ~~).
> 
Added description. 
> > Source/WebCore/dom/Range.cpp:1127
> > +    if (htmlElement->hasLocalName(colTag) || htmlElement->hasLocalName(colgroupTag) || htmlElement->hasLocalName(framesetTag)
> > +        || htmlElement->hasLocalName(headTag) || htmlElement->hasLocalName(styleTag) || htmlElement->hasLocalName(titleTag))
> > +        return 0;
> > +
> 
> Where did this code come from?  We need a test if we're making any behavioral changes.
> 
This is directly picked up from HTMLElement::deprecatedCreateContextualFragment. No new behavioral changes here.
> > Source/WebKit/qt/Api/qwebelement.cpp:1077
> > +    WebCore::Element* e = m_element;
> > +    Document* doc = e ? e->document() : 0;
> 
> I don't think m_element can be null here. See the the line above. We already call isHTMLElement on m_element. If m_element was null, then we would have blown up before reaching this line.

Yes agree with you. I have changed that part as per my previous comment. Please review that once. I will update the patch soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.