[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65834





--- Comment #19 from Dirk Pranke <dpranke at chromium.org>  2011-09-02 18:23:14 PST ---
(In reply to comment #18)
> There is any idea how we can merge correctly the different expectation lines?
> Anyway is that possible?
> 
> e.g.:
> BUGWKX :foo/bar.html=PASS //some comment
> BUGWKY LINUX:foo/bar.html=FAIL //other comment
> =
> BUGWKX BUGWKY: foo/bar.html = PASS FAIL //some comment; other comment
> 
> In that example the expectation line will be correct, but we don't see if there any regression.

Hi Kristóf, 

I'm not sure if I understood your question.

Using your example above, if you have:

BUGWKX :foo/bar.html=PASS //some comment
BUGWKY LINUX:foo/bar.html=FAIL //other comment

Today, you will actually get a parsing conflict, since the expectation is unclear on Linux.

[ At one point the code did actually support this, and the second line would've overridden the first, but we got rid of this because it made the code more complex and arguably made the expectations harder to follow (because you couldn't just look at a single line to figure out what a test was expected to do). ]

Of course, we can change the code. I think we need to start by defining what we want the syntax in the files to be, and the corresponding semantics.

For example, you could just #include something and merge the results to produce a flaky result as you describe, but as you say, this would not be a very good solution.

Another option would be to #include the files and just treat them as conflicts directly. As long as the files contained disjoint lists of tests, this woud be fine. This might be the way to start, as this would be pretty easy to support. Or, we could follow the model of the overrides files and just have later files trump earlier ones.

But, if we wanted to support something fancier, it's not immediately obvious to me how to do it without resorting to something like what I described earlier (where a line with more modifiers takes precedence over a line w/ fewer).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.