[Webkit-unassigned] [Bug 67229] ThreadableLoaderClient should support 'didDownloadData' updates

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67229





--- Comment #33 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-09-02 16:58:45 PST ---
(In reply to comment #31)
> > I don't agree.  As I've been saying, a network stack may provide a way to directly reference a file from the HTTP disk cache.  How can this be done by a higher layer?
> 
> This is quite different from what's being done here. A platform specific method to access a file in cache would certainly belong to ResourceHandle if deemed necessary, but I don't think that it would involve generic downloading progress callbacks.

Just for completeness, the idea is to provide an API that either transparently downloads a file or vends a file from the HTTP cache.  In the first case, progress events are quite important.  In the latter case, progress events are not necessary.


> I think that the patch has improved in that this code is no longer going to confuse people using ResourceHandle, although it is still not very good for people working on it. I would like to see a refactoring non-network parts of ResourceHandle into a separate class, as discussed before, and as we again discussed on IRC now. Given the apparent time constraints, it will have to be done later.

Thanks for understanding.  CQ+'ing this patch now.  Very happy to take ongoing feedback for improving this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.