[Webkit-unassigned] [Bug 67324] filter test_expectations properly for chromium-mac vs chromium-cg-mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 13:38:03 PDT 2011


--- Comment #16 from epoger at google.com  2011-09-02 13:38:02 PST ---
(In reply to comment #15)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (From update of attachment 106129 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=106129&action=review
> > > 
> > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:596
> > > > +        if self._graphics_type_cached is None:
> > > 
> > > None of the cpu/cpu-cg stuff belongs in this file. You should push all of this into chromium_mac.py and just override graphics_type() there.
> > 
> > I think these implementation details are very dependent on the resolution to Ojan's higher-level concerns.
> Sorry, I hadn't seen the discussion on that bug. I'm fine with the high-level approach. It's weird to me, but hopefully we'll be getting rid of CG entirely in the near future and then we can simplify the code again, so it's fine. The bit that confused me was that I didn't realize CPU/GPU implied Skia.

OK, I'll stick with the current high-level approach but try to address the lower-level concerns.  I'll update the bug with a new patch, probably on Tuesday morning, when it's ready for further review.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list