[Webkit-unassigned] [Bug 67324] filter test_expectations properly for chromium-mac vs chromium-cg-mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67324





--- Comment #14 from Dirk Pranke <dpranke at chromium.org>  2011-09-02 13:24:05 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 106129 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=106129&action=review
> > 
> > > Tools/Scripts/webkitpy/layout_tests/port/base.py:596
> > > +        if self._graphics_type_cached is None:
> > 
> > None of the cpu/cpu-cg stuff belongs in this file. You should push all of this into chromium_mac.py and just override graphics_type() there.
> 
> I think these implementation details are very dependent on the resolution to Ojan's higher-level concerns.
>  Dirk, do you have any thoughts on those concerns?
> 
> Thanks...

Ojan is right in theory that CG/Skia is orthogonal to CPU/GPU, and so it could be another modifier. In practice, though, I'm not sure that it matters that much, and in theory this is a short-lived transition, so I'd probably stick with the existing plan and expand the graphics_type to the four-modifier list. It's true that other ports could ignore the CG/Skia flag, but other (non-Chromium) ports don't even have the cpu/gpu concept.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.