[Webkit-unassigned] [Bug 67229] ThreadableLoaderClient should support 'didDownloadData' updates

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 13:09:31 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67229





--- Comment #24 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-09-02 13:09:30 PST ---
(In reply to comment #21)
> Data arrays are not conceptually different from what every port uses. It's just a different data format for efficiency, but you are still getting response data as normal.
> 
> WillCache/ShouldCache are a bit more unusual, but they still don't go beyond what every low level network loading API is concerned with.

Maybe you are biased toward the port you are most familiar with?  I could not tell you what those functions are for unless I spent some time studying the implementation code.  I would not feel comfortable refactoring those without reaching out to someone who is familiar with the CFNETWORK port, and that seems like the metric that matters most here.

> I'm not exactly sure what your proposal is. Is it just like Bill's latest patch, but with part of implementation being in .cpp files, I'm not sure if it's much progress over the first version.

>From comment #9, it would appear that Brady is not against this approach.  He at least seems to favor this over the original approach.

We are open to alternative solutions.  Simply asking us not to do this, when we have established that it is a reasonable and valuable thing for a network stack to implement (see comment #10, search for: "the purpose of this design is to enable optimizations"), does not seem constructive to me.  If you do not have a constructive alternative solution, then please at least allow us to proceed with what appears to be a par-for-the-course solution.  Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list