[Webkit-unassigned] [Bug 67056] Code Refactoring for HTMLElement::deprecatedCreateContextualFragment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 12:28:57 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67056





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-02 12:28:57 PST ---
(From update of attachment 106141)
View in context: https://bugs.webkit.org/attachment.cgi?id=106141&action=review

> Source/WebCore/ChangeLog:4
> +        Logic from HTMLElement::deprecatedCreateContextualFragment moved into
> +        Range::createContextualFragment function.

This line should match the bug title You should either rename the bug or replace this line by the actual bug title.

> Source/WebCore/ChangeLog:8
> +

You should add description here (keep the blank line after Reviewed by ~~).

> Source/WebCore/dom/Range.cpp:1127
> +    if (htmlElement->hasLocalName(colTag) || htmlElement->hasLocalName(colgroupTag) || htmlElement->hasLocalName(framesetTag)
> +        || htmlElement->hasLocalName(headTag) || htmlElement->hasLocalName(styleTag) || htmlElement->hasLocalName(titleTag))
> +        return 0;
> +

Where did this code come from?  We need a test if we're making any behavioral changes.

> Source/WebKit/qt/Api/qwebelement.cpp:1077
> +    WebCore::Element* e = m_element;
> +    Document* doc = e ? e->document() : 0;

I don't think m_element can be null here. See the the line above. We already call isHTMLElement on m_element. If m_element was null, then we would have blown up before reaching this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list