[Webkit-unassigned] [Bug 67458] Generate a WebKitCSSMatrix constructor of V8 using the IDL 'Constructor' extended attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67458





--- Comment #12 from anton muhin <antonm at chromium.org>  2011-09-02 11:27:18 PST ---
(In reply to comment #9)
> (From update of attachment 106074 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106074&action=review
> 
> >> Source/WebCore/bindings/v8/V8Binding.h:390
> >> +            if (m_v8Object.IsEmpty())
> > 
> > I would put it differently: if (m_v8Object.IsEmpty()) {  setString(String(); return true; } and remove all special cases below.
> 
> Does "all special cases below" mean the object().IsEmpty() checks in the line 459 and 469?
> 
> I think that we cannot remove those object().IsEmpty() checks, anyway. Please note that it is not object()->IsEmpty() but object().IsEmpty(). If we omit the object().IsEmpty() checks, the following object()->IsNull() causes SEGV if object() does not exist.

Yes, I meant that.  object()->IsEmpty() just doesn't exist.

You should be able to remove the checks as at least as of now, empty handles should never reach <WithNullCheck> or <WithUndefinedOrNullCheck> and, even with your change, can only appear on <Default> path.

And that's exactly the reason why I suggest you to add another conversion policy into V8Parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.