[Webkit-unassigned] [Bug 67458] Generate a WebKitCSSMatrix constructor of V8 using the IDL 'Constructor' extended attribute
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 2 11:06:00 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=67458
Kentaro Hara <haraken at google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106074|1 |0
is obsolete| |
--- Comment #9 from Kentaro Hara <haraken at google.com> 2011-09-02 11:06:00 PST ---
(From update of attachment 106074)
View in context: https://bugs.webkit.org/attachment.cgi?id=106074&action=review
>> Source/WebCore/bindings/v8/V8Binding.h:390
>> + if (m_v8Object.IsEmpty())
>
> I would put it differently: if (m_v8Object.IsEmpty()) { setString(String(); return true; } and remove all special cases below.
Does "all special cases below" mean the object().IsEmpty() checks in the line 459 and 469?
I think that we cannot remove those object().IsEmpty() checks, anyway. Please note that it is not object()->IsEmpty() but object().IsEmpty(). If we omit the object().IsEmpty() checks, the following object()->IsNull() causes SEGV if object() does not exist.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list