[Webkit-unassigned] [Bug 66323] Rename FontGtk.cpp to FontPango.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 10:51:57 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66323





--- Comment #19 from Rafael Antognolli <antognolli at profusion.mobi>  2011-09-02 10:51:56 PST ---
(In reply to comment #18)
> Attachment 106133 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/platform/graphics/pango/FontPango.cpp:337:  Missing space after ,  [whitespace/comma] [3]
> Source/WebCore/platform/graphics/pango/FontPango.cpp:355:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
> Source/WebCore/platform/graphics/pango/FontPango.cpp:426:  x_pos is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> Total errors found: 3 in 3 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

I didn't change this file on this patch, these errors were already there. Should I fix them too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list