[Webkit-unassigned] [Bug 66681] Need API for getting surrounding text from webkit in chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66681





--- Comment #44 from Peng Huang <penghuang at chromium.org>  2011-09-02 08:09:17 PST ---
(In reply to comment #43)
> Greetings,
> 
> This is just an off-the-topic question: it seems this change does not check whether the focused element is a password field. I'm wondering how this change prevents IMEs from reading text in password fields as [WebHTMLView attributedSubStringFromRange] does. If I recall correctly, Chrome OS has an IME extension API so extension developers can implement IMEs and virtual keyboards. If WebKit allows IMEs to read text in password fields, it may allow extension developers to read text in password fields. (I'm not sure if it is good to allow such extension developers to read text in other input fields.)
> 
> By the way, to implement [attributedSubstringFromRange:nsRange], Mac Chrome adds the WebKit::WebSubstringUtil class. Maybe we use this class for consistency? (Even though this is a random thought, it seems Mac Chrome uses a round-trip IPC request to implement this method. It might be better for a renderer to send attributed substring to a browser when it is changed to avoid such round-trip IPCs as we send cursor position?)

http://codereview.chromium.org/7824037/diff/1/content/renderer/render_widget.cc
Here is the related code in chromium. I plan check password field in chromium side. I think it is a little more efficient. Anyway, we could add check code in webkit as well.

At same time, it will notify input method any changes of surrounding text instead of sync round-trip IPCs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.