[Webkit-unassigned] [Bug 67254] [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 06:54:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67254





--- Comment #12 from Andras Becsi <abecsi at webkit.org>  2011-09-02 06:54:03 PST ---
Ok, in this case the call is superfluous indeed. I think the change can go. But let's wait for Ossy's verification first.

(In reply to comment #11)
> > > Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:257
> > > +    return url;
> > 
> > I think this should be "return QDir::toNativeSeparators(url);" so that the fallback case matches the previous behavior.
> 
> This change was in intentional.  What's provided to pathToLocalResource is always a URL for remapping if needed.  Turning all forward slashes into back slashes is unnecessary.  The function ought to be named "urlToLocalResource" or something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list