[Webkit-unassigned] [Bug 67254] [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67254





--- Comment #11 from Jarred Nicholls <jarred at sencha.com>  2011-09-02 06:42:13 PST ---
(In reply to comment #9)
> (From update of attachment 105939 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105939&action=review
> 
> I've CC'd Ossy who cares about this.
> 
> The change looks good to me except that you change the fallback behavior compared to the original approach.
> 
> > Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:257
> > +    return url;
> 
> I think this should be "return QDir::toNativeSeparators(url);" so that the fallback case matches the previous behavior.

This change was in intentional.  What's provided to pathToLocalResource is always a URL for remapping if needed.  Turning all forward slashes into back slashes is unnecessary.  The function ought to be named "urlToLocalResource" or something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.